repo/sceditor: src/sceditor.js comparison

comparison src/sceditor.js @ 16:8bd52902156a

remove "this" from command functions

author	Franklin Schmidt <fschmidt@gmail.com>
date	Sun, 07 Aug 2022 21:41:55 -0600
parents	ea930990b601
children	a199722647d0

comparison

equal deleted inserted replaced

-:ea930990b601
+:8bd52902156a
 		},
 		// END_COMMAND
 		// START_COMMAND: Left
 		left: {
-			state: function (node) {
+			state: function (editor, node) {
 				if (node && node.nodeType === 3) {
 					node = node.parentNode;
 				}
 				if (node) {
 			tooltip: 'Center'
 		},
 		// END_COMMAND
 		// START_COMMAND: Right
 		right: {
-			state: function (node) {
+			state: function (editor, node) {
 				if (node && node.nodeType === 3) {
 					node = node.parentNode;
 				}
 				if (node) {
 					}, true));
 				});
 				editor.createDropDown(caller, 'font-picker', content);
 			},
-			exec: function (caller) {
+			exec: function (editor,caller) {
-				var editor = this;
 				defaultCmds.font._dropDown(editor, caller, function (fontName) {
 					editor.execCommand('fontname', fontName);
 				});
 			},
 			tooltip: 'Font Name'
 					}, true));
 				}
 				editor.createDropDown(caller, 'fontsize-picker', content);
 			},
-			exec: function (caller) {
+			exec: function (editor,caller) {
-				var editor = this;
 				defaultCmds.size._dropDown(editor, caller, function (fontSize) {
 					editor.execCommand('fontsize', fontSize);
 				});
 			},
 			tooltip: 'Font Size'
 					e.preventDefault();
 				});
 				editor.createDropDown(caller, 'color-picker', content);
 			},
-			exec: function (caller) {
+			exec: function (editor,caller) {
-				var editor = this;
 				defaultCmds.color._dropDown(editor, caller, function (color) {
 					editor.execCommand('forecolor', color);
 				});
 			},
 			tooltip: 'Font Color'
 				'Please use the keyboard shortcut Ctrl/Cmd-V'
 		},
 		// END_COMMAND
 		// START_COMMAND: Paste Text
 		pastetext: {
-			exec: function (caller) {
+			exec: function (editor,caller) {
 				var	val,
-					content = createElement('div'),
+					content = createElement('div');
-					editor  = this;
 				appendChild(content, _tmpl('pastetext', {
 					label: editor._(
 						'Paste your text inside the following box:'
 					),
 			tooltip: 'Paste Text'
 		},
 		// END_COMMAND
 		// START_COMMAND: Bullet List
 		bulletlist: {
-			exec: function () {
+			exec: function (editor) {
-				fixFirefoxListBug(this);
+				fixFirefoxListBug(editor);
-				this.execCommand('insertunorderedlist');
+				editor.execCommand('insertunorderedlist');
 			},
 			tooltip: 'Bullet list'
 		},
 		// END_COMMAND
 		// START_COMMAND: Ordered List
 		orderedlist: {
-			exec: function () {
+			exec: function (editor) {
-				fixFirefoxListBug(this);
+				fixFirefoxListBug(editor);
-				this.execCommand('insertorderedlist');
+				editor.execCommand('insertorderedlist');
 			},
 			tooltip: 'Numbered list'
 		},
 		// END_COMMAND
 		// START_COMMAND: Indent
 		indent: {
-			state: function (parent, firstBlock) {
+			state: function (editor, parent, firstBlock) {
 				// Only works with lists, for now
 				var	range, startParent, endParent;
 				if (is(firstBlock, 'li')) {
 					return 0;
 					}
 				}
 				return -1;
 			},
-			exec: function () {
+			exec: function (editor) {
-				var editor = this,
+				var block = editor.getRangeHelper().getFirstBlockParent();
-					block = editor.getRangeHelper().getFirstBlockParent();
 				editor.focus();
 				// An indent system is quite complicated as there are loads
 				// of complications and issues around how to indent text
 			tooltip: 'Add indent'
 		},
 		// END_COMMAND
 		// START_COMMAND: Outdent
 		outdent: {
-			state: function (parents, firstBlock) {
+			state: function (editor, parents, firstBlock) {
 				return closest(firstBlock, 'ul,ol,menu') ? 0 : -1;
 			},
-			exec: function () {
+			exec: function (editor) {
-				var	block = this.getRangeHelper().getFirstBlockParent();
+				var	block = editor.getRangeHelper().getFirstBlockParent();
 				if (closest(block, 'ul,ol,menu')) {
-					this.execCommand('outdent');
+					editor.execCommand('outdent');
 				}
 			},
 			tooltip: 'Remove one indent'
 		},
 		// END_COMMAND
 		// START_COMMAND: Table
 		table: {
-			exec: function (caller) {
+			exec: function (editor,caller) {
-				var	editor  = this,
+				var	content = createElement('div');
-					content = createElement('div');
 				appendChild(content, _tmpl('table', {
 					rows: editor._('Rows:'),
 					cols: editor._('Cols:'),
 					insert: editor._('Insert')
 		},
 		// END_COMMAND
 		// START_COMMAND: Code
 		code: {
-			exec: function () {
+			exec: function (editor) {
-				this.wysiwygEditorInsertHtml(
+				editor.wysiwygEditorInsertHtml(
 					'<code>',
 					'<br /></code>'
 				);
 			},
 			tooltip: 'Code'
 					e.preventDefault();
 				});
 				editor.createDropDown(caller, 'insertimage', content);
 			},
-			exec: function (caller) {
+			exec: function (editor,caller) {
-				var	editor  = this;
 				defaultCmds.image._dropDown(
 					editor,
 					caller,
 					'',
 					function (url, width, height) {
 					e.preventDefault();
 				});
 				editor.createDropDown(caller, 'insertemail', content);
 			},
-			exec: function (caller) {
+			exec: function (editor,caller) {
-				var	editor  = this;
 				defaultCmds.email._dropDown(
 					editor,
 					caller,
 					function (email, text) {
 						if (!editor.getRangeHelper().selectedHtml() || text) {
 					}
 				}, EVENT_CAPTURE);
 				editor.createDropDown(caller, 'insertlink', content);
 			},
-			exec: function (caller) {
+			exec: function (editor,caller) {
-				var editor = this;
 				defaultCmds.link._dropDown(editor, caller, function (url, text) {
 					if (text || !editor.getRangeHelper().selectedHtml()) {
 						editor.wysiwygEditorInsertHtml(
 							'<a href="' + entities(url) + '">' +
 								entities(text || url) +
 		},
 		// END_COMMAND
 		// START_COMMAND: Unlink
 		unlink: {
-			state: function () {
+			state: function (editor) {
-				return closest(this.currentNode(), 'a') ? 0 : -1;
+				return closest(editor.currentNode(), 'a') ? 0 : -1;
 			},
-			exec: function () {
+			exec: function (editor) {
-				var anchor = closest(this.currentNode(), 'a');
+				var anchor = closest(editor.currentNode(), 'a');
 				if (anchor) {
 					while (anchor.firstChild) {
 						insertBefore(anchor.firstChild, anchor);
 					}
 		// END_COMMAND
 		// START_COMMAND: Quote
 		quote: {
-			exec: function (caller, html, author) {
+			exec: function (editor, caller, html, author) {
 				var	before = '<blockquote>',
 					end    = '</blockquote>';
 				// if there is HTML passed set end to null so any selected
 				// text is replaced
 						entities(author) +
 					'</cite>' : '');
 					before = before + author + html + end;
 					end    = null;
 				// if not add a newline to the end of the inserted quote
-				} else if (this.getRangeHelper().selectedHtml() === '') {
+				} else if (editor.getRangeHelper().selectedHtml() === '') {
 					end = '<br />' + end;
 				}
-				this.wysiwygEditorInsertHtml(before, end);
+				editor.wysiwygEditorInsertHtml(before, end);
 			},
 			tooltip: 'Insert a Quote'
 		},
 		// END_COMMAND
 		// START_COMMAND: Emoticons
 		emoticon: {
-			exec: function (caller) {
+			exec: function (editor, caller) {
-				var editor = this;
 				var createContent = function (includeMore) {
 					var	moreLink,
 						opts            = editor.opts,
 						emoticonsRoot   = opts.emoticonsRoot || '',
 						emoticonsCompat = opts.emoticonsCompat,
 					return content;
 				};
 				editor.createDropDown(caller, 'emoticons', createContent(false));
 			},
-			txtExec: function (caller) {
+			txtExec: function (editor, caller) {
-				defaultCmds.emoticon.exec.call(this, caller);
+				defaultCmds.emoticon.exec(editor, caller);
 			},
 			tooltip: 'Insert an emoticon'
 		},
 		// END_COMMAND
 					e.preventDefault();
 				});
 				editor.createDropDown(caller, 'insertlink', content);
 			},
-			exec: function (btn) {
+			exec: function (editor, btn) {
-				var editor = this;
 				defaultCmds.youtube._dropDown(editor, btn, function (id, time) {
 					editor.wysiwygEditorInsertHtml(_tmpl('youtube', {
 						id: id,
 						time: time
 					}));
 				return editor.opts.dateFormat
 					.replace(/year/i, year)
 					.replace(/month/i, month)
 					.replace(/day/i, day);
 			},
-			exec: function () {
+			exec: function (editor) {
-				this.insertText(defaultCmds.date._date(this));
+				editor.insertText(defaultCmds.date._date(editor));
 			},
-			txtExec: function () {
+			txtExec: function (editor) {
-				this.insertText(defaultCmds.date._date(this));
+				defaultCmds.date.exec(editor);
 			},
 			tooltip: 'Insert current date'
 		},
 		// END_COMMAND
 					secs = '0' + secs;
 				}
 				return hours + ':' + mins + ':' + secs;
 			},
-			exec: function () {
+			exec: function (editor) {
-				this.insertText(defaultCmds.time._time());
+				editor.insertText(defaultCmds.time._time());
 			},
-			txtExec: function () {
+			txtExec: function (editor) {
-				this.insertText(defaultCmds.time._time());
+				defaultCmds.time.exec(editor);
 			},
 			tooltip: 'Insert current time'
 		},
 		// END_COMMAND
 		// START_COMMAND: Ltr
 		ltr: {
-			state: function (parents, firstBlock) {
+			state: function (editor, parents, firstBlock) {
 				return firstBlock && firstBlock.style.direction === 'ltr';
 			},
-			exec: function () {
+			exec: function (editor) {
-				var	editor = this,
+				var	rangeHelper = editor.getRangeHelper(),
-					rangeHelper = editor.getRangeHelper(),
 					node = rangeHelper.getFirstBlockParent();
 				editor.focus();
 				if (!node || is(node, 'body')) {
 		},
 		// END_COMMAND
 		// START_COMMAND: Rtl
 		rtl: {
-			state: function (parents, firstBlock) {
+			state: function (editor, parents, firstBlock) {
 				return firstBlock && firstBlock.style.direction === 'rtl';
 			},
-			exec: function () {
+			exec: function (editor) {
-				var	editor = this,
+				var	rangeHelper = editor.getRangeHelper(),
-					rangeHelper = editor.getRangeHelper(),
 					node = rangeHelper.getFirstBlockParent();
 				editor.focus();
 				if (!node || is(node, 'body')) {
 		},
 		// END_COMMAND
 		// START_COMMAND: Maximize
 		maximize: {
-			state: function () {
+			state: function (editor) {
-				return this.maximize();
+				return editor.maximize();
 			},
-			exec: function () {
+			exec: function (editor) {
-				this.maximize(!this.maximize());
+				editor.maximize(!editor.maximize());
-				this.focus();
+				editor.focus();
 			},
 			txtExec: function () {
-				this.maximize(!this.maximize());
+				defaultCmds.maximize.exec(editor);
-				this.focus();
 			},
 			tooltip: 'Maximize',
 			shortcut: 'Ctrl+Shift+M'
 		},
 		// END_COMMAND
 		// START_COMMAND: Source
 		source: {
-			state: function () {
+			state: function (editor) {
-				return this.sourceMode();
+				return editor.sourceMode();
 			},
-			exec: function () {
+			exec: function (editor) {
-				this.toggleSourceMode();
+				editor.toggleSourceMode();
-				this.focus();
+				editor.focus();
 			},
-			txtExec: function () {
+			txtExec: function (editor) {
-				this.toggleSourceMode();
+				defaultCmds.source.exec(editor);
-				this.focus();
 			},
 			tooltip: 'View source',
 			shortcut: 'Ctrl+Shift+S'
 		},
 		// END_COMMAND
 					}
 					let iconName = command.icon || commandName
 					let shortcut = command.shortcut;
 					let button   = _tmpl('toolbarButton', {
+						name: commandName,
 						iconName: iconName,
-						name: commandName,
 						dispName: base._(command.name ||
 								command.tooltip || commandName)
 					}, true).firstChild;
 					if (icons.create) {
 			if (base.inSourceMode()) {
 				if (cmd.txtExec) {
 					if (Array.isArray(cmd.txtExec)) {
 						base.sourceEditorInsertText.apply(base, cmd.txtExec);
 					} else {
-						cmd.txtExec.call(base, caller, sourceEditorSelectedText());
+						cmd.txtExec(base, caller, sourceEditorSelectedText());
 					}
 				}
 			} else if (cmd.exec) {
 				if (isFunction(cmd.exec)) {
-					cmd.exec.call(base, caller);
+					cmd.exec(base, caller);
 				} else {
 					base.execCommand(
 						cmd.exec,
 						cmd.hasOwnProperty('execParam') ? cmd.execParam : null
 					);
 								state = doc.queryCommandState(stateFn) ? 1 : 0;
 							}
 						} catch (ex) {}
 					}
 				} else if (!isDisabled) {
-					state = stateFn.call(base, parent, firstBlock);
+					state = stateFn(base, parent, firstBlock);
 				}
 				toggleClass(btn, 'disabled', isDisabled || state < 0);
 				toggleClass(btn, 'active', state > 0);
 			}
 		 *     }
 		 * });
 		 *
 		 * @param {string} name
 		 * @param {Object} cmd
-		 * @return {this|false} Returns false if name or cmd is false
+		 * @return {true|false} Returns false if name or cmd is false
 		 * @since v1.3.5
 		 */
 		set: function (name, cmd) {
 			if (!name || !cmd) {
 				return false;
 			cmd.remove = function () {
 				SCEditor.command.remove(name);
 			};
 			defaultCmds[name] = cmd;
-			return this;
+			return true;
 		},
 		/**
 		 * Removes a command
 		 *
 		 * @param {string} name
-		 * @return {this}
 		 * @since v1.3.5
 		 */
 		remove: function (name) {
 			if (defaultCmds[name]) {
 				delete defaultCmds[name];
 			}
-			return this;
 		}
 	};
 	/**
 	 * SCEditor