Mercurial Hosting > sceditor
view src/changes.txt @ 39:9f63c8f506d1
simplify emoticons
author | Franklin Schmidt <fschmidt@gmail.com> |
---|---|
date | Thu, 18 Aug 2022 22:00:55 -0600 |
parents | cd02cd04bc9d |
children |
line wrap: on
line source
changes, most recent at top Removed complex parameterized tags: [tag value1=”xxx” value2=”yyy”]something[/tag] This is over-engineering and shouldn't be in BBCode. Removed sceditor.command with its get(), set(), and remove(). It is better to work with sceditor.commands directly. I also added an options.onCreate callback which lets one work with the final editor.commands . Remove DOMPurify. This was a huge amount of incomprehensible code that adds little value. XSS should basically be handled on the server side, and if one is using bbcode then it isn't an issue anyway. Removed "this" from command functions and instead pass "editor" as first arg. Javascript's object-oriented features are a disgusting hack and should never be used. I will remove uses of this as I encounter them. Add optional "icon" to command spec. Formats set default format so the "format" option isn't needed. Allow selector for textarea. CSS cleanup. Avoiding CSS includes is wrong for the same reason that minification is wrong. Changing icons required including a javascript file and setting the "icons" option. This is confusing so I got rid of the "icons" option. And I added icons/famfamfam.js as an option which is the default. Added examples/min.html and fixed defaults of 'style', 'width', and 'height'. 'width' defaults to 600 and 'height' defaults to 300. The dimensions of the textarea aren't used. This guarantees a reasonable default. fix emoticonsRoot Move /development/* to / Remove jQuery, another modern nightmare. Remove minified. Donald Knuth said "The real problem is that programmers have spent far too much time worrying about efficiency in the wrong places and at the wrong times; premature optimization is the root of all evil (or at least most of it) in programming." This certainly applies to minification of static files that are cached in the browser anyway. Not only is this pointless but it makes debugging more difficult and forces a build process. But of course modern scum programmers love this because they love pointless complexity. Add changes.txt Add serve.sh